CIS 2.1.1.1 should not fail if systemd-timesyncd is not installed #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karl DeBisschop <[email protected]>
Merged
kdebisschop
deleted the
CIS-2_1_1_1-should-not-fail-if-systemd-timesyncd-not-installed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall Review of Changes:
Added a check to "when' for checking if systemd-timesyncd.service is enabled.
Currently, if the package is not installed, the task fails because the systemd check is looking for a service that does not exist. It is clear from the CIS test code that not having the package installed is a valid configuration:
Note how in the CIS script, the systemctl test is only performed if the package is an available service. As a result, instead of reporting a failure, the test is skipped...which maybe is not perfect, but seems much better.
Issue Fixes:
Please list (using linking) any open issues this PR addresses
Enhancements:
Please list any enhancements/features that are not open issue tickets
How has this been tested?:
Has been run against instances without systemd-timesyncd installed. The test within the 2.1.1.1 block for the service is skipped instead of failing.