Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints to ArtifactLoader #1288

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Add type hints to ArtifactLoader #1288

merged 1 commit into from
Aug 17, 2023

Conversation

Shrews
Copy link
Contributor

@Shrews Shrews commented Jul 31, 2023 •
edited
Loading

  • Adds typing data to ArtifactLoader class.
  • Class method comments changed to conform to sphinx styling.
  • Makes get_contents() method private since it is not used outside of the class.

@Shrews Shrews force-pushed the type-artifactloader branch 5 times, most recently from 3206ca3 to 2995783 Compare July 31, 2023 19:03
@Shrews Shrews marked this pull request as ready for review August 1, 2023 18:40
@Shrews Shrews requested a review from a team as a code owner August 1, 2023 18:40
@Shrews Shrews added the code_health Issue/PR improves codebase health label Aug 2, 2023
@Shrews Shrews changed the title Add typing to ArtifactLoader Add type hints to ArtifactLoader Aug 15, 2023
@Shrews Shrews merged commit aac7fe1 into ansible:devel Aug 17, 2023
11 checks passed
@Shrews Shrews deleted the type-artifactloader branch August 17, 2023 17:14
@Shrews Shrews mentioned this pull request Aug 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akasurde Akasurde Akasurde approved these changes

Assignees
No one assigned
Labels
code_health Issue/PR improves codebase health
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shrews @Akasurde