Removes deprecated hook and replaces it with the current hook #2517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
AWX
AlexSCorey
force-pushed
the
removesDeprecatedDialogHook
branch
from
b107a5a to
2c6b9cf
Compare
AlexSCorey
changed the title
|
@AlexSCorey do we need tests to verify changes in this PR? |
AlexSCorey
changed the title
|
@h-kataria Since this does not bring in any functionality changes from a UI perspective I believe that current tests should be sufficient |
AlexSCorey
force-pushed
the
removesDeprecatedDialogHook
branch
from
2c6b9cf to
697c668
Compare
AlexSCorey
force-pushed
the
removesDeprecatedDialogHook
branch
from
697c668 to
ed490b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a deprecated usePagDialog hook and replaces it with usePageDialogs. no functionality should change.
In an effort to clean up our code base and remove deprecated items in order to improve our QOL and improve our testing issues I think this PR is pertinent.