Execution environments: accept empty description #15859
Conversation
github-actions
bot
added
component:awx_collection
|
| if description: | ||
| new_fields['description'] = description | ||
| if description is not None: | ||
| if description == '': |
There was a problem hiding this comment.
This is not needed, should be able to just use
if field_val is not None:
new_fields[field_name] = field_val
and if you provide a '' it will pass that along.
There was a problem hiding this comment.
Thank you, Sean. If I make the change and re-test do I have your commitment to review this one and a bunch more similar ones I submitted related to empty values in different modules and fields?
(I just don't fee like spending more time on all that if nobody will be looking)
There was a problem hiding this comment.
I can see about pushing the BU to review it, I'm just a frequent Contributor like you and caught this :) @kk-at-redhat
There was a problem hiding this comment.
@sean-m-sullivan good catch
@kk-at-redhat can you update this code, and the other "allow empty description" changes you made in the other PRs (that may already be merged)?
SUMMARY
related #15856
ISSUE TYPE
Bug, Docs Fix or other nominal change
COMPONENT NAME
Collection
AWX VERSION
ADDITIONAL INFORMATION
See linked ticket for testing steps