Skip to content

Add ssh-agent mount to template file #15868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from

Conversation

thedoubl3j
Copy link
Member

SUMMARY

Add ssh mount for more ease of use when in local dev env. I am open to conditionalizing this but just wanted to get this out here since I was hitting issues previously when keys were needed.

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • Other
AWX VERSION
devel
ADDITIONAL INFORMATION

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.35%. Comparing base (cd0e274) to head (db73bfa).
Report is 1 commits behind head on devel.

✅ All tests successful. No failed tests found.

❌ Your project check has failed because the head coverage (74.35%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlanCoding
Copy link
Member

In various checks I see:

 Container tools_redis_1  Created
 Container tools_postgres_1  Created
 Container tools_awx_1  Creating
Error response from daemon: invalid mount config for type "bind": bind source path does not exist: /ssh-agent
make[1]: *** [Makefile:521: docker-compose-up] Error 1
make[1]: Leaving directory '/home/runner/work/awx/awx'
make: *** [Makefile:515: docker-compose] Error 2

Maybe there are some other actions that need this applied as well?

@thedoubl3j
Copy link
Member Author

@AlanCoding might also be a typo on my part, ran into this locally. will recheck here in the next day or so.

@@ -53,6 +54,9 @@ services:
- service-mesh
working_dir: "/awx_devel"
volumes:
- type: bind
source: /ssh-agent
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this wont work

* add ssh mount for more ease of local dev
@@ -54,6 +55,9 @@ services:
- service-mesh
working_dir: "/awx_devel"
volumes:
- type: bind
source: /run/user/1000/keyring/ssh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlanCoding AlanCoding added the needs_investigation PRs or issues that need further investigation label Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs_investigation PRs or issues that need further investigation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants