-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Add ssh-agent mount to template file #15868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. ❌ Your project check has failed because the head coverage (74.35%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage. 🚀 New features to boost your workflow:
|
In various checks I see:
Maybe there are some other actions that need this applied as well? |
@AlanCoding might also be a typo on my part, ran into this locally. will recheck here in the next day or so. |
@@ -53,6 +54,9 @@ services: | |||
- service-mesh | |||
working_dir: "/awx_devel" | |||
volumes: | |||
- type: bind | |||
source: /ssh-agent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this wont work
* add ssh mount for more ease of local dev
|
@@ -54,6 +55,9 @@ services: | |||
- service-mesh | |||
working_dir: "/awx_devel" | |||
volumes: | |||
- type: bind | |||
source: /run/user/1000/keyring/ssh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SUMMARY
Add ssh mount for more ease of use when in local dev env. I am open to conditionalizing this but just wanted to get this out here since I was hitting issues previously when keys were needed.
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION