-
Notifications
You must be signed in to change notification settings - Fork 74
Adding missing help_text and check #647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
john-westcott-iv
merged 1 commit into
ansible:devel
from
john-westcott-iv:help_text_check
Nov 26, 2024
Merged
Adding missing help_text and check #647
john-westcott-iv
merged 1 commit into
ansible:devel
from
john-westcott-iv:help_text_check
Nov 26, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cd8f8aa
to
b6d9126
Compare
AlanCoding
reviewed
Nov 13, 2024
AlanCoding
reviewed
Nov 13, 2024
AlanCoding
reviewed
Nov 13, 2024
AlanCoding
reviewed
Nov 13, 2024
AlanCoding
reviewed
Nov 13, 2024
AlanCoding
reviewed
Nov 13, 2024
AlanCoding
reviewed
Nov 13, 2024
AlanCoding
reviewed
Nov 13, 2024
AlanCoding
reviewed
Nov 13, 2024
b6d9126
to
3c97fb3
Compare
BrennanPaciorek
suggested changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More migrations appear to be necessary.
check: exit 1 (1.02 seconds) /home/runner/work/django-ansible-base/django-ansible-base> python3 manage.py makemigrations --check
The other comments are just recommendations and lightly-held opinions.
3c97fb3
to
54c1c68
Compare
54c1c68
to
1a30cf4
Compare
839ab3b
to
1c1018d
Compare
BrennanPaciorek
approved these changes
Nov 25, 2024
tznamena
reviewed
Nov 25, 2024
3fe445f
to
db504d4
Compare
db504d4
to
f5827d5
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a help_text check, validating that every model has all of its help_text defined.
It also addresses missing help_text from existing models.