Skip to content

Adding missing help_text and check #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

john-westcott-iv
Copy link
Member

This adds a help_text check, validating that every model has all of its help_text defined.

It also addresses missing help_text from existing models.

@john-westcott-iv john-westcott-iv force-pushed the help_text_check branch 4 times, most recently from cd8f8aa to b6d9126 Compare November 13, 2024 19:42
Copy link
Contributor

@BrennanPaciorek BrennanPaciorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More migrations appear to be necessary.

check: exit 1 (1.02 seconds) /home/runner/work/django-ansible-base/django-ansible-base> python3 manage.py makemigrations --check

The other comments are just recommendations and lightly-held opinions.

@john-westcott-iv john-westcott-iv force-pushed the help_text_check branch 2 times, most recently from 3fe445f to db504d4 Compare November 26, 2024 19:34
Copy link

@john-westcott-iv john-westcott-iv merged commit a65e8f7 into ansible:devel Nov 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants