Skip to content

AAP-36381: Make SAML username/permid required #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 5, 2025

Conversation

bhavenst
Copy link
Contributor

Description

Some time back, attr_user_permanent_id and attr_username were made nullable/not-required since the docs make it seem like that is acceptable. It however is not and authentication fails without either of them. The docs have already been updated to state they are required, but the UI still shows them as optional. This just makes them required in the UI.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Test update
  • Refactoring (no functional changes)
  • Development environment change
  • Configuration change

Self-Review Checklist

  • I have performed a self-review of my code
  • I have added relevant comments to complex code sections
  • I have updated documentation where needed
  • I have considered the security impact of these changes
  • I have considered performance implications
  • I have thought about error handling and edge cases
  • I have tested the changes in my local environment

Testing Instructions

Prerequisites

Steps to Test

  1. Try to create a SAML authenticator without specifying one or both of these params.
  2. See that it's not accepted.

Expected Results

Impossible to create SAML authenticator without username and permanent ID fields.

Additional Context

N/A

@bhavenst bhavenst force-pushed the aap-36381 branch 5 times, most recently from 0114f90 to e35ea14 Compare May 2, 2025 16:58
Copy link

github-actions bot commented May 5, 2025

DVCS PR Check Results:

PR appears valid (JIRA key(s) found)

Copy link

sonarqubecloud bot commented May 5, 2025

@zkayyali812 zkayyali812 merged commit a46ebe5 into ansible:devel May 5, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants