Skip to content

[WIP] Allow customizing settings module from get_setting #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: devel
Choose a base branch
from

Conversation

AlanCoding
Copy link
Member

Description

For dynamic settings, we may not save all settings in the same settings module

Practically, I countered this with the AWX job template callback view. Somehow, the code from that made it into DAB, which referenced django.conf.settings, but I need awx.conf.db_settings

Type of Change

  • Test update
  • Refactoring (no functional changes)

Self-Review Checklist

  • I have performed a self-review of my code
  • I have added relevant comments to complex code sections
  • I have updated documentation where needed
  • I have considered the security impact of these changes
  • I have considered performance implications
  • I have thought about error handling and edge cases
  • I have tested the changes in my local environment

Testing Instructions

Can only be functional combined with changes elsewhere

Prerequisites

none

Steps to Test

Needs dynamic settings patches in other components

Expected Results

Unblocks that other work

Additional Context

Required Actions

Screenshots/Logs

Copy link

github-actions bot commented Jun 9, 2025

DVCS PR Check Results:

Could not find JIRA key(s) in PR title, branch name, or commit messages

Copy link

sonarqubecloud bot commented Jun 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
1 New issue

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@john-westcott-iv john-westcott-iv changed the title Allow customizing settings module from get_setting [WIP] Allow customizing settings module from get_setting Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant