[WIP] Allow customizing settings module from get_setting #744
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For dynamic settings, we may not save all settings in the same settings module
Practically, I countered this with the AWX job template callback view. Somehow, the code from that made it into DAB, which referenced
django.conf.settings
, but I needawx.conf.db_settings
Type of Change
Self-Review Checklist
Testing Instructions
Can only be functional combined with changes elsewhere
Prerequisites
none
Steps to Test
Needs dynamic settings patches in other components
Expected Results
Unblocks that other work
Additional Context
Required Actions
Screenshots/Logs