Skip to content

[AAP-48713] Alter authenticator maps to work with attribute expansion #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 16, 2025

Conversation

john-westcott-iv
Copy link
Member

@john-westcott-iv john-westcott-iv commented Jul 15, 2025

Description

  • What is being changed?
    If you add the syntax {% for_attr_value(<attribute name>) %} to an authenticator map we will expand that value based on the values returned from an attribute on login.

  • Why is this change needed?
    This will make gateway backwards compatible with an obscure SAML setting from AWX.

  • How does this change address the issue?
    This allows authenticator maps to behave like the SAML authenticator can.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Test update
  • Refactoring (no functional changes)
  • Development environment change
  • Configuration change

Self-Review Checklist

  • I have performed a self-review of my code
  • I have added relevant comments to complex code sections
  • I have updated documentation where needed
  • I have considered the security impact of these changes
  • I have considered performance implications
  • I have thought about error handling and edge cases
  • I have tested the changes in my local environment

Testing Instructions

Prerequisites

Steps to Test

  1. Setup an authenticator which return multiple attribute values
  2. Create authenticator maps that expand values
  3. Login through the authenticator
  4. Assert that the values were expanded as expected

Expected Results

Additional Context

Required Actions

  • Requires documentation updates
  • Requires downstream repository changes
  • Requires infrastructure/deployment changes
  • Requires coordination with other teams
  • Blocked by PR/MR: #XXX

Screenshots/Logs

@john-westcott-iv john-westcott-iv force-pushed the AAP-48713 branch 2 times, most recently from 7d387eb to 2196043 Compare July 15, 2025 20:31
Copy link
Member

@AlanCoding AlanCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't really seem to change a lot long along the interface that matters with other systems, and fairly clear what this is doing and why it is needed.

Copy link

DVCS PR Check Results:

PR appears valid (JIRA key(s) found)

Copy link

@john-westcott-iv john-westcott-iv merged commit f1ec423 into ansible:devel Jul 16, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants