Skip to content

AAP-47841 authenticator and authenticator map view permission updates to allow service token access #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tyraziel
Copy link
Contributor

@tyraziel tyraziel commented Jul 15, 2025

Description

  • What is being changed? Added allow_service_token = True to authenticator and autenticator_map view.
  • Why is this change needed? The management command in controller needs this to allow service tokens to be used between controller and gateway.
  • How does this change address the issue? Enables service tokens to be used.

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Configuration change

Self-Review Checklist

  • I have performed a self-review of my code
  • I have added relevant comments to complex code sections
  • I have updated documentation where needed
  • I have considered the security impact of these changes
  • I have considered performance implications
  • I have thought about error handling and edge cases
  • I have tested the changes in my local environment

@tyraziel tyraziel marked this pull request as ready for review July 15, 2025 21:12
@tyraziel tyraziel changed the title AAP 47841 authenticator and authenticator map view permission updates to allow service token access AAP-47841 authenticator and authenticator map view permission updates to allow service token access Jul 15, 2025
@tyraziel tyraziel force-pushed the AAP-47841-svc-tkn-view-permission-updates branch from 27c01b3 to 996a92f Compare July 15, 2025 21:21
Copy link

@pb82 pb82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tyraziel are these the only changes required to allow POST, PATCH and GET requests for authenticators and mappers?

@tyraziel
Copy link
Contributor Author

tyraziel commented Jul 16, 2025

@tyraziel are these the only changes required to allow POST, PATCH and GET requests for authenticators and mappers?

All that was needed for the GitHub authenticator was GET and POST during my testing.

I do see PATCH being used in some of the update calls, will get that added.

@tyraziel tyraziel force-pushed the AAP-47841-svc-tkn-view-permission-updates branch from 996a92f to d5f42c0 Compare July 16, 2025 18:49
Copy link

DVCS PR Check Results:

PR appears valid (JIRA key(s) found)

@zkayyali812 zkayyali812 enabled auto-merge (rebase) July 16, 2025 18:50
Copy link

@zkayyali812 zkayyali812 merged commit 71d129c into ansible:devel Jul 16, 2025
13 checks passed
@tyraziel tyraziel deleted the AAP-47841-svc-tkn-view-permission-updates branch July 16, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants