-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass etc_hosts through to docker_container module if set in molecule config #1571
Conversation
Hi @jzafran, thanks for your contribution! Please rebase this PR on top of master. |
Signed-off-by: Jeremy Zafran <[email protected]>
@webknjaz all set; I've rebased it onto the latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a test needed and then we're good! Thanks for this PR!
@@ -75,6 +75,7 @@ | |||
networks: "{{ item.networks | default(omit) }}" | |||
network_mode: "{{ item.network_mode | default(omit) }}" | |||
dns_servers: "{{ item.dns_servers | default(omit) }}" | |||
etc_hosts: "{{ item.etc_hosts | default(omit) }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to mark with review interface. Please see #1571 (comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please could you add some tests?
Closing due to lack of activity. |
PR Type
Set
etc_hosts
parameter when usingdocker_container
Ansible module increate.yml
, which makes it possible to add entries to/etc/hosts
in the container (it's not possible to modify that file once the container is started) ifetc_hosts
is set in theplatforms
item.For example:
Results in an entry in
/etc/hosts