Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create consistent workunit IDs across all nodes #1194

Merged
merged 9 commits into from
Nov 12, 2024

Conversation

matoval
Copy link
Collaborator

@matoval matoval commented Oct 24, 2024

Create consistent workunit IDs across all nodes by passing workunit ID to remote node

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 37.03704% with 17 lines in your changes missing coverage. Please review.

Project coverage is 44.19%. Comparing base (5312a25) to head (ce3292e).
Report is 10 commits behind head on devel.

Files with missing lines Patch % Lines
pkg/workceptor/workceptor.go 56.25% 6 Missing and 1 partial ⚠️
pkg/workceptor/controlsvc.go 0.00% 6 Missing ⚠️
pkg/workceptor/remote_work.go 0.00% 4 Missing ⚠️
@@            Coverage Diff             @@
##            devel    #1194      +/-   ##
==========================================
+ Coverage   43.98%   44.19%   +0.21%     
==========================================
  Files          33       36       +3     
  Lines        8090     8745     +655     
==========================================
+ Hits         3558     3865     +307     
- Misses       4261     4609     +348     
  Partials      271      271              
Files with missing lines Coverage Δ
pkg/controlsvc/controlsvc.go 74.19% <100.00%> (ø)
pkg/workceptor/remote_work.go 10.83% <0.00%> (-0.35%) ⬇️
pkg/workceptor/controlsvc.go 5.30% <0.00%> (-0.06%) ⬇️
pkg/workceptor/workceptor.go 49.55% <56.25%> (-0.11%) ⬇️

... and 9 files with indirect coverage changes

Components Coverage Δ
Go 43.83% <37.03%> (-0.15%) ⬇️
Receptorctl 49.31% <ø> (∅)

Copy link

sonarcloud bot commented Oct 31, 2024

Copy link
Contributor

@AaronH88 AaronH88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Matthew ran integration tests with his changes and the new work unit id's do not break anything with the stack above.

Good to merge.

@AaronH88 AaronH88 merged commit 25ff7aa into ansible:devel Nov 12, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants