Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add no lint flags for false positives #825

Closed
wants to merge 1 commit into from
Closed

Add no lint flags for false positives #825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions pkg/netceptor/conn.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ type acceptResult struct {
type Listener struct {
s *Netceptor
pc *PacketConn
ql quic.Listener
ql quic.Listener //nolint:typecheck
acceptChan chan *acceptResult
doneChan chan struct{}
doneOnce *sync.Once
Expand Down Expand Up @@ -89,11 +89,11 @@ func (s *Netceptor) listen(ctx context.Context, service string, tlscfg *tls.Conf
pc.startUnreachable()
s.Logger.Debug("%s added service %s to listener registry", s.nodeID, service)
s.listenerRegistry[service] = pc
cfg := &quic.Config{
cfg := &quic.Config{ //nolint:typecheck
MaxIdleTimeout: MaxIdleTimeoutForQuicConnections,
}
_ = os.Setenv("QUIC_GO_DISABLE_RECEIVE_BUFFER_WARNING", "1")
ql, err := quic.Listen(pc, tlscfg, cfg)
ql, err := quic.Listen(pc, tlscfg, cfg) //nolint:typecheck
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -262,8 +262,8 @@ func (li *Listener) Addr() net.Addr {
type Conn struct {
s *Netceptor
pc *PacketConn
qc quic.Connection
qs quic.Stream
qc quic.Connection //nolint:typecheck
qs quic.Stream //nolint:typecheck
doneChan chan struct{}
doneOnce *sync.Once
ctx context.Context
Expand All @@ -283,7 +283,7 @@ func (s *Netceptor) DialContext(ctx context.Context, node string, service string
return nil, err
}
rAddr := s.NewAddr(node, service)
cfg := &quic.Config{
cfg := &quic.Config{ //nolint:typecheck
HandshakeIdleTimeout: 15 * time.Second,
MaxIdleTimeout: MaxIdleTimeoutForQuicConnections,
}
Expand Down Expand Up @@ -319,7 +319,7 @@ func (s *Netceptor) DialContext(ctx context.Context, node string, service string
doneChan := make(chan struct{}, 1)
go monitorUnreachable(pc, doneChan, rAddr, ccancel)
_ = os.Setenv("QUIC_GO_DISABLE_RECEIVE_BUFFER_WARNING", "1")
qc, err := quic.DialContext(cctx, pc, rAddr, s.nodeID, tlscfg, cfg)
qc, err := quic.DialContext(cctx, pc, rAddr, s.nodeID, tlscfg, cfg) //nolint:typecheck
if err != nil {
close(okChan)
pcClose()
Expand Down
2 changes: 1 addition & 1 deletion tests/functional/mesh/lib.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ func (n *LibNode) StartListeners() error {

for _, listenerCfg := range n.ListenerCfgs {
switch lcfg := listenerCfg.(type) {
case *backends.TCPListenerCfg:
case *backends.TCPListenerCfg: //nolint:typecheck
bi, err = n.TCPListen(listenerCfg)

// Record what address we are listening on so we can reuse it if we restart this node
Expand Down
Loading