Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add namespace argument to helm template, fix #9 #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danni-m
Copy link

@danni-m danni-m commented May 14, 2018

No description provided.

@mhrivnak
Copy link
Member

Thank you for this. Could you just elaborate on why it is needed? Perhaps provide an example use case?

@mhrivnak
Copy link
Member

Oh I see, this fixes #9

Do you have an example use case that we could test with?

@danni-m
Copy link
Author

danni-m commented May 15, 2018

@mhrivnak Sure, any reference to the destination namespace will not work.
For example, in redis-enterprise we create a service account and a role for managing local namespace resources (we do not want to use ClusterRole since we don't need that).
Any RoleBinding needs a reference for the namespace of the service account.
Here is our RoleBinding YAML template for example:
https://github.com/RedisLabs/redislabs-helm/blob/master/redis-enterprise/templates/rolebinding.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants