Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace lodash/assignWith with vanilla js #6543

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

guoyunhe
Copy link
Contributor

@guoyunhe guoyunhe commented Feb 6, 2024

能进一步减少打包体积

@guoyunhe guoyunhe force-pushed the drop-lodash-assign-with branch 2 times, most recently from 7c36a96 to 8e9f9cb Compare February 6, 2024 14:11
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.34%. Comparing base (937f845) to head (cc0078f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6543      +/-   ##
==========================================
- Coverage   92.34%   92.34%   -0.01%     
==========================================
  Files         318      318              
  Lines        6910     6909       -1     
  Branches     1729     1729              
==========================================
- Hits         6381     6380       -1     
  Misses        493      493              
  Partials       36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 6, 2024

PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6543.surge.sh

@afc163
Copy link
Member

afc163 commented Feb 7, 2024

先加个 size-limit action? 这样能看出优化效果。

ant-design/ant-design#47375 (comment)

@guoyunhe guoyunhe force-pushed the drop-lodash-assign-with branch from 8e9f9cb to 07d0acb Compare March 15, 2024 09:00
@guoyunhe guoyunhe force-pushed the drop-lodash-assign-with branch from 07d0acb to cc0078f Compare March 18, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants