feat: add button link type #6679
Open
+29
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 24, 2024 13:37
|
PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6679.surge.sh |
|
Seems CI failed. Pls check |
guoyunhe
reviewed
Jul 26, 2024
src/components/button/button.less
Outdated
| @@ -91,6 +91,9 @@ | |||
| &-warning { | |||
| --color: var(--adm-color-warning); | |||
| } | |||
| &-link { | |||
| color: var(--adm-color-primary); | |||
There was a problem hiding this comment.
I think it is better to have separate CSS variable for link --adm-color-link, some themes' primary color is different from links. CC @zombieJ
There was a problem hiding this comment.
I think it is better to have separate CSS variable for link
--adm-color-link, some themes' primary color is different from links. CC @zombieJ
done
added 2 commits
July 30, 2024 18:11
|
Seems the style is same as 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #6616