Skip to content

Comments

fix: genStyleUtils doesn't work when realToken is undefined#17

Closed
YumoImer wants to merge 1 commit intomasterfrom
fix/useToken
Closed

fix: genStyleUtils doesn't work when realToken is undefined#17
YumoImer wants to merge 1 commit intomasterfrom
fix/useToken

Conversation

@YumoImer
Copy link
Contributor

该 PR 主要修复当使用 genStyleUtils 时,传入的 options.useToken 未返回 realToken 时,空指针导致 genStyleUtils 无法正常工作。

实际上:options.useToken 返回的 realTokencssVar 仅被使用于 DEV 环境,不应该影响 genStyleUtils 的正常运行。

@YumoImer YumoImer requested a review from zombieJ August 23, 2024 08:23
@codecov
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.44%. Comparing base (4d829bf) to head (29ebad2).

Files Patch % Lines
src/util/genStyleUtils.tsx 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   84.00%   83.44%   -0.56%     
==========================================
  Files          11       11              
  Lines         300      302       +2     
  Branches       73       81       +8     
==========================================
  Hits          252      252              
- Misses         48       50       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YumoImer YumoImer closed this Aug 23, 2024
@YumoImer
Copy link
Contributor Author

并非 dev only ,待重新提 PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant