fix: 修复刷新之后 label 丢失的情况#8982
Merged
chenshuai2144 merged 1 commit intoant-design:masterfrom Feb 17, 2025
Merged
Conversation
|
⚡️ Deploying PR Preview... |
Wxh16144
reviewed
Jan 20, 2025
Comment on lines
-299
to
+302
| label: preserveOriginalLabel ? dataItem?.label : value.label, | ||
| // 这里有一种情况，如果用户使用了 request和labelInValue，保存之后，刷新页面，正常回显，但是再次添加会出现 label 丢失的情况。所以需要兼容 | ||
| label: preserveOriginalLabel | ||
| ? dataItem?.label || value.label | ||
| : value.label, |
Member
There was a problem hiding this comment.
注释部分应该贴一个 issue 地址，或者复现地址，不熟悉的人 review 可能想象不到这个 case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
如果用户使用了 request和labelInValue，保存之后，刷新页面，正常回显，但是再次添加会出现 label 丢失的情况。所以需要兼容