Conversation
…r testing Co-authored-by: 陈帅 <[email protected]>
|
Cursor Agent can help with this pull request. Just |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (14)
📝 Walkthrough走查本次变更为布局、表格和列表组件添加 变更
估计代码审查工作量🎯 2 (简单) | ⏱️ ~8 分钟 诗歌
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求旨在通过向多个核心视图组件添加 Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| return props.ErrorBoundary === false ? ( | ||
| <Layout.Content className={contentClassName} style={style}> | ||
| <Layout.Content | ||
| className={contentClassName} | ||
| style={style} | ||
| data-testid="pro-layout-content" | ||
| > | ||
| {children} | ||
| </Layout.Content> | ||
| ) : ( | ||
| <ErrorComponent> | ||
| <Layout.Content className={contentClassName} style={style}> | ||
| <Layout.Content | ||
| className={contentClassName} | ||
| style={style} | ||
| data-testid="pro-layout-content" | ||
| > | ||
| {children} | ||
| </Layout.Content> | ||
| </ErrorComponent> |
There was a problem hiding this comment.
这部分代码存在重复。Layout.Content 组件在三元运算符的两个分支中都出现了。为了提高代码的可维护性并减少重复，建议将其提取到一个变量中。
(() => {
const contentNode = (
<Layout.Content
className={contentClassName}
style={style}
data-testid="pro-layout-content"
>
{children}
</Layout.Content>
);
return props.ErrorBoundary === false ? (
contentNode
) : (
<ErrorComponent>{contentNode}</ErrorComponent>
);
})()
dosubot
bot
added
the
size:M
There was a problem hiding this comment.
Pull request overview
该 PR 为核心视图组件补充稳定的 data-testid 属性，便于应用侧在自动化测试中使用 Testing Library（如 screen.getByTestId）定位关键结构节点。
Changes:
- 为
ProTable、ProList根节点增加固定data-testid - 为
ProLayout及其关键区域组件（Header/Sider/Content/Footer 等）增加固定data-testid - 为
PageContainer、PageHeader、GridContent、GlobalFooter/GlobalHeader等增加固定data-testid
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/table/Table.tsx | 为 ProTable 根容器增加 data-testid="pro-table" |
| src/list/ProListBase.tsx | 为 ProList 视图根节点增加 data-testid="pro-list-view" |
| src/layout/ProLayout.tsx | 为 ProLayout 根节点增加 data-testid="pro-layout" |
| src/layout/WrapContent.tsx | 为主内容区增加 data-testid="pro-layout-content" |
| src/layout/components/Header/index.tsx | 为布局 Header 增加 data-testid="pro-layout-header" |
| src/layout/components/Footer.tsx | 为布局 Footer 增加 data-testid="pro-layout-footer" |
| src/layout/components/GlobalHeader/index.tsx | 为 GlobalHeader 增加 data-testid="pro-layout-global-header" |
| src/layout/components/TopNavHeader/index.tsx | 为 TopNavHeader 增加 data-testid="pro-layout-top-nav-header" |
| src/layout/components/SiderMenu/index.tsx | 为移动端 Drawer 侧边栏容器增加 data-testid="pro-layout-sider" |
| src/layout/components/SiderMenu/SiderMenu.tsx | 为 Sider（侧边栏）增加 data-testid="pro-layout-sider" |
| src/layout/components/PageContainer/index.tsx | 为 PageContainer 增加 data-testid="pro-page-container" |
| src/layout/components/PageHeader/index.tsx | 为 PageHeader 增加 data-testid="pro-page-header" |
| src/layout/components/GridContent/index.tsx | 为 GridContent 增加 data-testid="pro-grid-content" |
| src/layout/components/GlobalFooter/index.tsx | 为 GlobalFooter 增加 data-testid="pro-global-footer" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <Drawer | ||
| placement={direction === 'rtl' ? 'right' : 'left'} | ||
| className={clsx(`${prefixCls}-drawer-sider`, className)} | ||
| data-testid="pro-layout-sider" |
There was a problem hiding this comment.
SiderMenu 在移动端渲染时这里给 Drawer 设置了 data-testid="pro-layout-sider"，同时 Drawer 内部会渲染 SiderMenu 组件本身（其 Sider 也设置了相同的 data-testid）。这会导致页面上同时出现两个相同的 test id，screen.getByTestId('pro-layout-sider') 会因匹配到多个元素而报错。建议仅在移动端给 Drawer 设置该 test id（并在 Sider 上移除/条件禁用），或为 Drawer/Sider 使用不同的 id。
| data-testid="pro-layout-sider" | |
| data-testid="pro-layout-sider-drawer" |
| onCollapse?.(collapse); | ||
| }} | ||
| collapsedWidth={collapsedWidth} | ||
| data-testid="pro-layout-sider" |
There was a problem hiding this comment.
这里的 Sider 设置了 data-testid="pro-layout-sider"，但在移动端该组件会被包在 SiderMenuWrapper 的 Drawer 内部，而 Drawer 也设置了同样的 data-testid，从而产生重复的 test id。建议根据 isMobile 条件化该属性（例如仅在非移动端设置在 Sider 上），或与 Drawer 使用不同的 test id。
| data-testid="pro-layout-sider" | |
| data-testid={!isMobile ? 'pro-layout-sider' : undefined} |
| <div | ||
| className={clsx(className, { | ||
| [`${defaultClassName}-polling`]: action.pollingLoading, | ||
| })} | ||
| style={style} | ||
| ref={counter.rootDomRef} | ||
| data-testid="pro-table" | ||
| > |
There was a problem hiding this comment.
此处新增 data-testid="pro-table" 是该 PR 的关键行为之一，但目前看不到对应的单测覆盖（例如渲染 ProTable 后断言根节点存在该 test id）。建议在现有 tests/table/* 中补一条回归测试，避免后续重构/包装 DOM 时意外移除该属性。
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Free Tier Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Duplicate
data-testidon sider in mobile mode- Removed the duplicate
data-testidfrom the mobileDrawerso only the innerSiderexposespro-layout-siderin all modes.
- Removed the duplicate
Or push these changes by commenting:
@cursor push 8f941c9825
Preview (8f941c9825)
diff --git a/src/layout/components/SiderMenu/index.tsx b/src/layout/components/SiderMenu/index.tsx
--- a/src/layout/components/SiderMenu/index.tsx
+++ b/src/layout/components/SiderMenu/index.tsx
@@ -52,7 +52,6 @@
<Drawer
placement={direction === 'rtl' ? 'right' : 'left'}
className={clsx(`${prefixCls}-drawer-sider`, className)}
- data-testid="pro-layout-sider"
open={!collapsed}
afterOpenChange={(open) => {
if (!open) {This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
为主要视图组件添加
data-testid属性，以方便自动化测试。此PR为
ProList、ProLayout及其子组件、ProTable和PageContainer等核心视图组件增加了data-testid属性，便于在测试中通过screen.getByTestId等方法定位元素。data-testidProListContainer/ListViewpro-list-viewProLayoutpro-layoutHeaderpro-layout-headerSiderMenu(侧边栏 / Drawer)pro-layout-siderWrapContent(主内容区)pro-layout-contentFooterpro-layout-footerGlobalHeaderpro-layout-global-headerTopNavHeaderpro-layout-top-nav-headerPageContainerpro-page-containerPageHeaderpro-page-headerGridContentpro-grid-contentGlobalFooterpro-global-footerProTablepro-tableSummary by CodeRabbit
发布说明