Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete webpack.config.js #229

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Nov 24, 2024

这个文件疑似没用了。

circular-dependency-plugin

@madccc/duplicate-package-checker-webpack-plugin

这两个后续需要挪到 father 配置里。

Summary by CodeRabbit

  • 文档
    • 删除了与构建分发文件相关的 Webpack 配置文件 webpack.config.js

Copy link
Contributor

coderabbitai bot commented Nov 24, 2024

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough
📝 Walkthrough
📝 Walkthrough
📝 Walkthrough
📝 Walkthrough
📝 Walkthrough
📝 Walkthrough
📝 Walkthrough
📝 Walkthrough
📝 Walkthrough
📝 Walkthrough

Walkthrough

此次变更删除了 webpack.config.js 文件,该文件包含了用于构建分发文件的 Webpack 配置。配置中导入了多个插件,并定义了外部依赖和优化设置。主要逻辑包括获取基础 Webpack 配置,并根据环境变量进行条件检查,以应用外部依赖和优化设置。最终,模块导出了配置好的 Webpack 配置数组。

Changes

文件 变更摘要
webpack.config.js 删除了包含 Webpack 构建配置的文件,配置涉及多个插件和外部依赖。

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Webpack
    participant Plugins

    User->>Webpack: 触发构建
    Webpack->>Plugins: 加载插件
    Plugins-->>Webpack: 返回插件配置
    Webpack->>User: 生成构建文件
Loading

在兔子洞里忙碌的兔子,
删除配置,轻松无忧,
构建过程如春风拂面,
插件舞动,代码流畅,
兔子欢跳,庆祝新生! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Nov 24, 2024

Preview is ready

Copy link

codecov bot commented Nov 24, 2024

Bundle Report

Bundle size has no change ✅

Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.13%. Comparing base (f3e7883) to head (7a1044e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #229   +/-   ##
=======================================
  Coverage   91.13%   91.13%           
=======================================
  Files          66       66           
  Lines        1421     1421           
  Branches      364      379   +15     
=======================================
  Hits         1295     1295           
  Misses        126      126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@afc163 afc163 marked this pull request as draft November 24, 2024 05:22
Copy link

cloudflare-workers-and-pages bot commented Nov 24, 2024

Deploying ant-design-x with  Cloudflare Pages  Cloudflare Pages

Latest commit: fe8f4d5
Status: ✅  Deploy successful!
Preview URL: https://d94b69bb.ant-design-x.pages.dev
Branch Preview URL: https://chore-remove-webpack-config.ant-design-x.pages.dev

View logs

Copy link

size-limit report 📦

Path Size
dist/antdx.min.js 45.72 KB

@afc163 afc163 force-pushed the chore/remove-webpack.config.js branch from 7a1044e to 0d4506d Compare November 25, 2024 03:30
@afc163
Copy link
Member Author

afc163 commented Nov 25, 2024

error - Error: @babel/runtime
  Multiple versions of @babel/runtime found:
    7.23.6 ./~/@umijs/babel-preset-umi/~/@babel/runtime from ./components/sender/index.tsx
    7.26.0 ./~/@babel/runtime from ./~/rc-util/lib/pickAttrs.js

@afc163
Copy link
Member Author

afc163 commented Dec 5, 2024

Waiting for umijs/umi#12803

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant