-
-
Notifications
You must be signed in to change notification settings - Fork 730
feat: New Actions #768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: New Actions #768
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b3efeaa
feat: init actions
63283da
feat: del useless code
4fe41e2
Merge branch 'feature' into actions
vanndxh 702c050
feat: opt docs for Actions
1aadd2c
fix: actions test
be4b447
feat: add actions snap
40031ae
feat: add displayName
ba74cba
feat: actions opt
695b6de
fix: test
82e35c6
fix: update snap
8dbd02a
feat: add menu click test
0fff548
feat: update sub item click test
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
import { EllipsisOutlined } from '@ant-design/icons'; | ||
import { Dropdown, MenuProps } from 'antd'; | ||
import React from 'react'; | ||
import { ActionsProps } from '.'; | ||
import { useXProviderContext } from '../x-provider'; | ||
import { ActionItem, ItemType } from './interface'; | ||
|
||
export const findItem = (keyPath: string[], items: ActionItem[]): ActionItem | null => { | ||
const keyToFind = keyPath[0]; // Get the first key from the keyPath | ||
|
||
for (const item of items) { | ||
if (item.key === keyToFind) { | ||
// If the item is found and this is the last key in the path | ||
if (keyPath.length === 1) return item; | ||
|
||
// If it is a SubItemType, recurse to find in its children | ||
if ('children' in item) { | ||
return findItem(keyPath.slice(1), item.children!); | ||
} | ||
} | ||
} | ||
|
||
return null; | ||
}; | ||
|
||
const ActionMenu = (props: { item: ItemType } & Pick<ActionsProps, 'prefixCls' | 'onClick'>) => { | ||
const { onClick: onMenuClick, item } = props; | ||
const { children = [], triggerSubMenuAction = 'hover' } = item; | ||
const { getPrefixCls } = useXProviderContext(); | ||
const prefixCls = getPrefixCls('actions', props.prefixCls); | ||
const icon = item?.icon ?? <EllipsisOutlined />; | ||
|
||
const menuProps: MenuProps = { | ||
items: children, | ||
onClick: ({ key, keyPath, domEvent }) => { | ||
if (findItem(keyPath, children)?.onItemClick) { | ||
findItem(keyPath, children)?.onItemClick?.(findItem(keyPath, children) as ActionItem); | ||
return; | ||
} | ||
onMenuClick?.({ | ||
key, | ||
keyPath: [...keyPath, item.key], | ||
domEvent, | ||
item: findItem(keyPath, children)!, | ||
}); | ||
}, | ||
}; | ||
|
||
return ( | ||
<Dropdown | ||
menu={menuProps} | ||
overlayClassName={`${prefixCls}-sub-item`} | ||
arrow | ||
trigger={[triggerSubMenuAction]} | ||
> | ||
<div className={`${prefixCls}-list-item`}> | ||
<div className={`${prefixCls}-list-item-icon`}>{icon}</div> | ||
</div> | ||
</Dropdown> | ||
); | ||
}; | ||
|
||
export default ActionMenu; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
findItem
function assumes thatchildren
is always defined when it exists in an item. Consider adding a check to ensurechildren
is not undefined before accessing it to prevent potential runtime errors.