Fix clip creator timing due to last ts file not written #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
last commit was to the wrong branch so it is reverted, sorry for that |
|
|
burak-58
approved these changes
Jun 2, 2025
| @@ -202,7 +202,11 @@ public void createRecordings() | |||
| { | |||
| vertx.executeBlocking(() -> | |||
| { | |||
| convertHlsToMp4(broadcast, true); | |||
| long endTime = System.currentTimeMillis(); | |||
| vertx.setTimer(2100, (l) -> { | |||
There was a problem hiding this comment.
Why we set a timer with a magic number 2100?
| } | ||
| return false; | ||
| } | ||
|
|
||
| public static boolean createMp4(File tsFileList, String outputFilePath) { |
There was a problem hiding this comment.
It seems that this is not used anymore, right? If yes, we can delete it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.