[TS] Add property versions of raw fields to TS #4574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JS properties exist for the `_type` and `_input` fields, but they aren't present in the typescript definition file. This commit adds those properties. The commit adds doc comments pointing developers toward the corresponding properties. I don't know if there's a deprication process for removing the old fields. `inputStream`'s setter function does a reset of the lexer, but otherwise the properties are normal. Signed-off-by: Phlosioneer <[email protected]>
ericvergnaud
requested changes
Apr 6, 2024
| @@ -7,15 +7,23 @@ export declare class Lexer extends Recognizer<number> { | |||
|
|
|||
| static DEFAULT_MODE: number; | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Please use
/**
* @deprecated .../...
*/
There was a problem hiding this comment.
@Phlosioneer Hi there, it's been a while... any progress ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS properties exist for the
_typeand_inputfields, but they aren't present in the typescript definition file. This commit adds those properties.The commit adds doc comments pointing developers toward the corresponding properties. I don't know if there's a deprication process for removing the old fields.
inputStream's setter function does a reset of the lexer, but otherwise the properties are normal.