Skip to content

fix(JS: BitSet): Export the BitSet class #4746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2025
Merged

Conversation

hutcheb
Copy link
Contributor

@hutcheb hutcheb commented Dec 12, 2024

As the BitSet class is now used in the ErrorListener class it should be exported as users are required to implement these new functions which use the BitSet class as one of their parameters.

It expands on #4731

@ericvergnaud
Copy link
Contributor

@hutcheb Thanks for this.
Some tests were cancelled due to CI configuration.
This is now fixed, but I'm not able to re-run it for this PR.
Can you rebase such that we can check that the CI fully succeeds ?

@ericvergnaud
Copy link
Contributor

@parrt blessed

@parrt parrt merged commit cb85012 into antlr:dev Apr 3, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants