Fix "chrono" C++ library not being included on Windows #4779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Linux, the build is successful because this library is usually included in the headers by default. But on Windows, when using Visual Studio (at least VS 2022 Community - the version I tested this on), the build fails because the "chrono" library is not included by default. To avoid troubling new Windows adopters of this C++ runtime, it would be good to include this in the code! (Adding this line does not break builds on Linux, and does not cause any warnings on Windows or Linux! - I test it this on both Windows and Linux) Signed-off-by: 0xENDER <[email protected]>
|
I was about to do this exact same PR. Thanks @0xENDER. |
|
Duplicate of #4738 |
Contributor
Author
|
This change has been made through a different pull request |
kaby76
added a commit
to kaby76/Trash
that referenced
this pull request
Mar 4, 2025
Required to bypass compilation errors. antlr/antlr4#4779
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux, the build is successful because this library is usually included in the headers by default. But on Windows, when using Visual Studio (at least VS 2022 Community - the version I tested this on), the build fails because the "chrono" library is not included by default.
To avoid troubling new Windows adopters of this C++ runtime, it would be good to include this in the code!
(Adding this line does not break builds on Linux, and does not cause any warnings on Windows or Linux! - I tested it on both Windows and Linux)