Fix a CMake v4.0.0 build error (related to googletest)
#4808
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake version 4.0.0 doesn't support the currently used `googletest` CMake project version. As such, updating the project to the latest version makes sense. Signed-off-by: 0xENDER <[email protected]>
Draft
4 tasks
Contributor
|
We are now seeing this in builds for grammars-v4 for Windows. |
hamidelmaazouz
left a comment
hamidelmaazouz
left a comment
There was a problem hiding this comment.
question on the runtime tests, do they still pass after this change ?
hamidelmaazouz
approved these changes
May 24, 2025
Contributor
Author
|
I'd have to assume yes (since the GitHub tests didn't fail, and because of the way the Google tests repository is maintained with little importance to versioning) |
Contributor
|
@parrt blessed |
|
yay ! thanks a lot @0xENDER @ericvergnaud and @parrt 😄 |
martinjonas
pushed a commit
to martinjonas/Q3B
that referenced
this pull request
Sep 17, 2025
This is a temporary workaround for antlr/antlr4#4808 until a new release of ANTLR is released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake version 4.0.0 doesn't support the currently used
googletestCMake project version. As such, updating the project to the latest version makes sense.(This closes #4807)