Skip to content

feat: catch error and add error render ui #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 18, 2025
Merged

feat: catch error and add error render ui #153

merged 7 commits into from
Jul 18, 2025

Conversation

XinyueDu
Copy link
Contributor

@XinyueDu XinyueDu commented Jul 16, 2025

PR includes

  • fixed #0
  • add / modify test cases
  • documents, demos

Screenshot

image image image

错误渲染:
image

Before After

Copy link

changeset-bot bot commented Jul 16, 2025

🦋 Changeset detected

Latest commit: e04260b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@antv/gpt-vis Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@XinyueDu XinyueDu changed the title Error render tmp feat: catch error and add error render ui Jul 16, 2025
Copy link
Contributor

github-actions bot commented Jul 16, 2025

🎊 PR Preview e04260b has been successfully built and deployed to https://antvis-GPT-Vis-preview-pr-153.surge.sh

🕐 Build time: 15.149s

🤖 By surge-preview

@hustcc
Copy link
Member

hustcc commented Jul 16, 2025

现在只剩下按钮使用非 antd 去写了。另外 antd 的依赖可以不用动,我看 VisText 还有使用到,所以使用的 peer 依赖。

@hustcc hustcc merged commit 68fd0fd into main Jul 18, 2025
7 checks passed
@hustcc hustcc deleted the error-render-tmp branch July 18, 2025 06:32
@BoyYangzai
Copy link
Member

麻烦抽空发个新包哈!业务需要这部分

@github-actions github-actions bot mentioned this pull request Jul 18, 2025
@hustcc
Copy link
Member

hustcc commented Jul 18, 2025

@BoyYangzai https://github.com/antvis/GPT-Vis/releases/tag/v0.5.0

@BoyYangzai
Copy link
Member

BoyYangzai commented Jul 21, 2025

这个 pr 貌似存在一些问题哈 不清楚是否符合你们预期 可以看看
1.这两个错误的渲染方式差距太大 本来是期望(个人 不清楚你们那边业务的需求)一个配置就可以同时自定义渲染这两种错误 现在需要分别配置 render !?
image
image
2. 问题1 中 图1 和文档中居中的效果不一致
image
且自定义的配置不生效
image

还有 另外问一句 这个 图表 | 代码 的样式不错
但是缺少国际化能力?项目全部有国际化 中文太突兀了TAT
可以抽成 chartContainer? 因为刚好之前就想统一在图表这里加一个 点击展开 modal 的放大效果按钮来着 没地方支持
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants