[RLlib] Introduce RLlib Intro template #392
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven1977
changed the title
sven1977
changed the title
sven1977
reviewed
Nov 18, 2024
sven1977
reviewed
Nov 18, 2024
|
cc: @aslonnie @GokuMohandas as well |
sven1977
reviewed
Nov 20, 2024
sven1977
reviewed
Nov 20, 2024
templates/intro-rllib/atari_ppo.py
Outdated
| ) | ||
|
|
||
| config.resources(num_gpus=0) | ||
| config.learners( |
There was a problem hiding this comment.
Let's move these into the main config bracket above.
sven1977
reviewed
Nov 20, 2024
templates/intro-rllib/atari_ppo.py
Outdated
| num_gpus_per_learner=1, | ||
| ) | ||
|
|
||
| config.env_runners(num_env_runners=95) |
There was a problem hiding this comment.
this, too (move these into the main config bracket above).
sven1977
reviewed
Nov 20, 2024
templates/intro-rllib/atari_ppo.py
Outdated
| ) | ||
| .training( | ||
| learner_connector=_make_learner_connector, | ||
| train_batch_size_per_learner=4000, # 5000 on old yaml example |
There was a problem hiding this comment.
Note: With the approach we are establish now as per our last offline conversation, this won't work anymore, since we copy the config from the tuned example from the ray repo.
sven1977
reviewed
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a template for RLlib.
Context -> https://docs.google.com/document/d/1UxNRSnOZ7QkZi1sw2e5mpSZ9xg-hBQw0rMzmuUe_MA0/edit?tab=t.0#heading=h.a084zdxe2jqv