Skip to content

upd: General cleanup #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 28, 2025
Merged

upd: General cleanup #11

merged 7 commits into from
Jan 28, 2025

Conversation

brent-anyscale
Copy link
Collaborator

General cleanup of README, outputs, etc.

On branch brent/general-updates
Changes to be committed:
modified: README.md
modified: examples/aws/eks-private/outputs.tf
modified: examples/aws/eks-public/main.tf
modified: examples/aws/eks-public/outputs.tf
modified: modules/anyscale-k8s-helm/README.md
new file: modules/anyscale-k8s-helm/helm-aws-loadbalancer.tf
modified: modules/anyscale-k8s-helm/variables.tf

Pull request checklist

Please check if your PR fulfills the following requirements:

  • pre-commit has been run
  • Tests for the changes have been added (for bug fixes / features)
  • All tests passing
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Pull Request Type

  • Bugfix
  • New feature
  • Refactoring (no functional changes)
  • Documentation change
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

On branch brent/general-updates
Changes to be committed:
	modified:   README.md
	modified:   examples/aws/eks-private/outputs.tf
	modified:   examples/aws/eks-public/main.tf
	modified:   examples/aws/eks-public/outputs.tf
	modified:   modules/anyscale-k8s-helm/README.md
	new file:   modules/anyscale-k8s-helm/helm-aws-loadbalancer.tf
	modified:   modules/anyscale-k8s-helm/variables.tf
@brent-anyscale brent-anyscale requested a review from a team as a code owner January 28, 2025 00:17
@github-actions github-actions bot added documentation Improvements or additions to documentation examples terraform labels Jan 28, 2025
Copy link
Member

@hongchaodeng hongchaodeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after nit

hongchaodeng and others added 6 commits January 28, 2025 07:45
On branch brent/general-updates
Changes to be committed:
	modified:   README.md
	modified:   examples/aws/eks-private/outputs.tf
	modified:   examples/aws/eks-public/main.tf
	modified:   examples/aws/eks-public/outputs.tf
	modified:   modules/anyscale-k8s-helm/README.md
	new file:   modules/anyscale-k8s-helm/helm-aws-loadbalancer.tf
	modified:   modules/anyscale-k8s-helm/variables.tf
Changes to be committed:
	modified:   README.md
Changes to be committed:
	modified:   README.md
@brent-anyscale brent-anyscale merged commit 9073d33 into main Jan 28, 2025
3 checks passed
@brent-anyscale brent-anyscale deleted the brent/general-updates branch January 28, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation examples terraform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants