Skip to content

example: add gke-public #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 25, 2025
Merged

example: add gke-public #15

merged 3 commits into from
Mar 25, 2025

Conversation

hongchaodeng
Copy link
Member

@hongchaodeng hongchaodeng commented Mar 19, 2025

This PR adds the example to create public GKE cluster for running Anyscale workloads.
Tested both CPU and GPU workspaces.

Pull request checklist

Please check if your PR fulfills the following requirements:

  • pre-commit has been run
  • Tests for the changes have been added (for bug fixes / features)
  • All tests passing
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Pull Request Type

  • Bugfix
  • New feature
  • Refactoring (no functional changes)
  • Documentation change
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Other information

@hongchaodeng hongchaodeng requested a review from a team as a code owner March 19, 2025 23:53
@github-actions github-actions bot added documentation Improvements or additions to documentation examples labels Mar 19, 2025
Renamed gke-public to gke-new_cluster and added sample-values_nginx_gke_private.yaml and sample-values_nginx_gke_public.yaml

Additional updates to pre-commit for Trivy, and updated the README and CHANGELOG

Changes to be committed:
	modified:   .gitignore
	modified:   .pre-commit-config.yaml
	modified:   CHANGELOG.md
	modified:   README.md
	modified:   examples/gcp/gke-existing_cluster/README.md
	renamed:    examples/gcp/gke-public/README.md -> examples/gcp/gke-new_cluster/README.md
	renamed:    examples/gcp/gke-public/gke.tf -> examples/gcp/gke-new_cluster/gke.tf
	renamed:    examples/gcp/gke-public/main.tf -> examples/gcp/gke-new_cluster/main.tf
	renamed:    examples/gcp/gke-public/outputs.tf -> examples/gcp/gke-new_cluster/outputs.tf
	new file:   examples/gcp/gke-new_cluster/sample-values_nginx_gke_private.yaml
	new file:   examples/gcp/gke-new_cluster/sample-values_nginx_gke_public.yaml
	new file:   examples/gcp/gke-new_cluster/variables.tf
	renamed:    examples/gcp/gke-public/versions.tf -> examples/gcp/gke-new_cluster/versions.tf
	deleted:    examples/gcp/gke-public/variables.tf
	modified:   modules/anyscale-k8s-configmap/README.md
	modified:   modules/anyscale-k8s-helm/README.md
	modified:   modules/anyscale-k8s-namespace/README.md
	modified:   modules/anyscale-k8s-persistent-volume/README.md
	new file:   trivy.yaml
Signed-off-by: hongchaodeng <[email protected]>
Copy link
Collaborator

@brent-anyscale brent-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brent-anyscale brent-anyscale merged commit 141e64f into main Mar 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation examples terraform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants