fix: Tolerances for EKS nodes need to be ON_DEMAND #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to be committed: modified: examples/aws/eks-private/main.tf
Switches the ALL tolerance to ON_DEMAND, as taints must be unique to a tuple of (key, effect) in EKS, which wasn't possible with the ALL convention Changes to be committed: modified: eks-private/main.tf modified: eks-public/main.tf
github-actions
bot
added
documentation
Changes to be committed: modified: CHANGELOG.md
shomilj
approved these changes
Sep 16, 2024
sudhirn-anyscale
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the ALL tolerance to ON_DEMAND, as taints must be unique to a tuple of (key, effect) in EKS, which wasn't possible with the ALL convention
Changes to be committed:
modified: eks-private/main.tf
modified: eks-public/main.tf
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull Request Type
Does this introduce a breaking change?