Skip to content

[ingress-nginx] add config "annotations-risk-leve: Critical" #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2025
Merged

[ingress-nginx] add config "annotations-risk-leve: Critical" #29

merged 1 commit into from
Jun 27, 2025

Conversation

hongchaodeng
Copy link
Member

@hongchaodeng hongchaodeng commented Jun 27, 2025 •
edited
Loading

Starting from nginx ingress controller 1.12.1, you need to add annotations-risk-level: Critical if you need to allow-snippet-annotations: true.

Pull request checklist

Please check if your PR fulfills the following requirements:

  • pre-commit has been run
  • Tests for the changes have been added (for bug fixes / features)
  • All tests passing
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Pull Request Type

  • Bugfix
  • New feature
  • Refactoring (no functional changes)
  • Documentation change
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Other information

@hongchaodeng hongchaodeng requested a review from a team as a code owner June 27, 2025 01:01
@github-actions github-actions bot added documentation Improvements or additions to documentation examples labels Jun 27, 2025
brent-anyscale
brent-anyscale approved these changes Jun 27, 2025
View reviewed changes
Copy link
Collaborator

@brent-anyscale brent-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the super fast turnaround!

@hongchaodeng hongchaodeng merged commit 4ef3bc9 into main Jun 27, 2025
3 checks passed
@hongchaodeng hongchaodeng deleted the hdeng/nginx branch June 27, 2025 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brent-anyscale brent-anyscale brent-anyscale approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hongchaodeng @brent-anyscale