Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugs/5791 remove unused enum #85

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Bugs/5791 remove unused enum #85

merged 2 commits into from
Sep 10, 2024

Conversation

utas-raymondng
Copy link
Collaborator

@utas-raymondng utas-raymondng commented Sep 10, 2024 •
edited
Loading

Duplicate enum one with "s" one without, favor the enum with "s"

@utas-raymondng utas-raymondng requested review from vietnguyengit and removed request for vietnguyengit September 10, 2024 01:24
HavierD
HavierD approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@HavierD HavierD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@HavierD HavierD merged commit 8cc3ff9 into main Sep 10, 2024
2 checks passed
@HavierD HavierD deleted the bugs/5791-remove-unused-enum branch September 10, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HavierD HavierD HavierD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@utas-raymondng @HavierD