return 404 if didn't find an uuid #89
Conversation
| @@ -39,7 +39,7 @@ public ResponseEntity<Collection> getCollection(String id, String sortBy) throws | |||
| return ResponseEntity.ok() | |||
| .body(StacToCollection.convert(model.getCollections().get(0))); | |||
| } else { | |||
| throw new NoSuchElementException(String.format("uuid %s not found!", id)); | |||
| return ResponseEntity.notFound().build(); | |||
There was a problem hiding this comment.
can you add more details to the returning message than simply 404 http status code?
There was a problem hiding this comment.
after double-checking, i found this function want to return: ResponseEntity<Colleciton>, so i can only set body whose type is a Collection. For not messing up this function, i think only 404 code is enough for this situation, because the client side knows the url and uuid.
There was a problem hiding this comment.
so cannot do something like this?
return ResponseEntity.status(HttpStatus.NOT_FOUND).body(String.format("uuid %s not found!", id));There was a problem hiding this comment.
or, having a log log.error(...); before returning 404 code.
There was a problem hiding this comment.
so you don't have to make the controller method returning type using raw ResponseEntity.
There was a problem hiding this comment.
so cannot do something like this?
return ResponseEntity.status(HttpStatus.NOT_FOUND).body(String.format("uuid %s not found!", id));
yes this is what i tried, but it only want a Collection type for the body
So i use raw ResponseEntity before, not setting body for it.
There was a problem hiding this comment.
can you please try, otherwise missing out what previously tried to inform.
the client side is ok, knows the uuid and the NOT_FOUND status. For the server side output, do you think adding a log.error() is ok?
There was a problem hiding this comment.
yep, you can just print the log if too much hassles to deal with, I think the previous impl to get some traces for what happened should stay. I've seen animaltracking controllers always use raw ResponseEntity type for the method declaration.
| @@ -39,7 +39,7 @@ public ResponseEntity<Collection> getCollection(String id, String sortBy) throws | |||
| return ResponseEntity.ok() | |||
| .body(StacToCollection.convert(model.getCollections().get(0))); | |||
| } else { | |||
| throw new NoSuchElementException(String.format("uuid %s not found!", id)); | |||
| return ResponseEntity.notFound().build(); | |||
vietnguyengit
deleted the
feature/5918-return-404-for-not-found-uuid
branch
No description provided.