Conversation
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...aven-plugin/src/main/kotlin/com/github/aoudiamoncef/apollo/plugin/util/UnsafeOkHttpClient.kt
Fixed
Show fixed
Hide fixed
...aven-plugin/src/main/kotlin/com/github/aoudiamoncef/apollo/plugin/util/UnsafeOkHttpClient.kt
Fixed
Show fixed
Hide fixed
|
Additional Information: |
|
Thanks for your contribution. Try to split PR into small tasks Don't worry about formatting,I'll do with It. |
|
Hi @aoudiamoncef, Can you elaborate on that? |
|
Any news on this? At least the code generation looks good. |
|
Haven't heard back from @aoudiamoncef yet 🙂 |
|
Hi @aoudiamoncef any plans to merge this? |
| compilerParams.schemaPackageName = "${project.groupId}.apollo.client.${service.compilationUnit.name}.schema" | ||
| } | ||
|
|
||
| if (compilerParams.targetLanguage == TargetLanguage.JAVA) { |
There was a problem hiding this comment.
Display warnings is more appropriate here.
| executableFiles = graphqlFiles.toInputFiles(), | ||
| irOptions = irOptions, | ||
| codegenOptions = codegenOptions, | ||
| layoutFactory = null, // ToDo: plugin?.layout(codegenSchema) |
There was a problem hiding this comment.
IMHO, the easiest way is to let the user instanciate a classe like we did operationOutputGenerator
| <generateFilterNotNull>false</generateFilterNotNull> | ||
| <generateFragmentImplementations>false</generateFragmentImplementations> | ||
| <generateResponseFields>false</generateResponseFields> | ||
| <generateQueryDocument>true</generateQueryDocument> |
There was a problem hiding this comment.
the goal is to show all params, just remove the old value to make it null
|
@aoudiamoncef thanks for the comments! |
- warnings instead of exceptions in ConfigUtils - user-instantiated classes for layoutFactory - test POM params cleaned to allow null/defaults
|
| arrayOf<TrustManager>( | ||
| object : X509TrustManager { | ||
| @Throws(CertificateException::class) | ||
| override fun checkClientTrusted( |
Check failure
Code scanning / SonarCloud
Server certificates should be verified during SSL/TLS connections High
| override fun checkServerTrusted(chain: Array<java.security.cert.X509Certificate>, authType: String) { | ||
| } | ||
| @Throws(CertificateException::class) | ||
| override fun checkServerTrusted( |
Check failure
Code scanning / SonarCloud
Server certificates should be verified during SSL/TLS connections High
|
@aoudiamoncef is there any chance there will be a release with this PR merged so we can use Apollo 4.0.x? Code generation looks good as far as I can tell. @cgoller-evia In Apollo 4 there is no support for compiler parameter schemaPackageName. This property is actually not doing anything right now. Apollo 4 latest release is 4.3.3. When this PR is merged there's still no support for Apollo 4.3.x because of some apollo-compiler-plugin internal api changes. I have forked this branch and made it work for Apollo 4.3.3. This is not backwards compatible with Apollo 4.0.x because of the apollo-compiler-plugin changes. I didn't test 4.1.x and 4.2.x Maybe we can make some effort to release a working plugin for a 4.0.x version and the latest 4.3.x version? |
5 participants
POC Apollo 4 Migration
Initial Effort to implement #93.
Still missing (as far as I can tell):
Any feedback/help is appreciated.