Corrected integration time values for the OceanFX #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ap--
approved these changes
Mar 4, 2024
ap--
reviewed
Mar 4, 2024
| const long FlameXSpectrometerFeature::INTEGRATION_TIME_INCREMENT = 1000; | ||
| const long FlameXSpectrometerFeature::INTEGRATION_TIME_MINIMUM = 10; | ||
| const long FlameXSpectrometerFeature::INTEGRATION_TIME_MAXIMUM = 10000000; | ||
| const long FlameXSpectrometerFeature::INTEGRATION_TIME_INCREMENT = 1; |
There was a problem hiding this comment.
Can you confirm that this actually works?
Changing the integration time increment usually influences the way the usb communication works.
There was a problem hiding this comment.
Hi @padalev,
it would be great if you could confirm the above
|
@padalev in case you have time, it would be great if you could confirm that your change works, and that integration times are not off by a factor of 1000. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stored values for the integration time of the OceanFX in libseabreeze were not correct.
I corrected the values with this minor change.