Adds the concept of a publisher #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lets us lean on this lib with git coordinates instead of publishing a jar.
* A publisher can only send jobs to faktory * No need to register jobs to use a publisher * A publisher has an associated connection but no work will be done to keep it alive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some applications will only publish events to faktory. Using the worker model is not ideal in these cases.
This change adds a publisher that can only be used to publish events. The connection is not managed and will timeout if not used frequently enough. It will automatically reconnect if the socket was closed.
It looks like there could be a threading issue with publishing events concurrently, since they will use the same socket instance without anything preventing concurrent access. An application could pool publishers to deal with this or use a new connection every time.
From this page:
https://github.com/contribsys/faktory/blob/main/docs/protocol-specification.md
Clients that are not consumers MUST NOT send BEAT commands, and MUST NOT enter the Quiet or Terminating stages.