Adds tests for inner and outer joins #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests added in the joins_test.clj. Behavior also tested by running commands in the RethinkDB website interface to mitigate the chances of errors in the commands.
|
@apa512 Any reason this can't be merged? |
|
Looks good, probably got lost in the shuffle of new years. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happy New Years!
This test adds commits as mentioned by #117. All tests passed when run on my machine.
Tests added in the joins_test.clj. Behavior also tested by running
commands in the RethinkDB website interface to mitigate the chances of
errors in the commands.