added Pause option into minor compactions #5289
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlmarion
requested changes
Jan 29, 2025
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java
Outdated
Show resolved
Hide resolved
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactionTask.java
Outdated
Show resolved
Hide resolved
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java
Outdated
Show resolved
Hide resolved
| @@ -603,9 +603,9 @@ private MinorCompactionTask createMinorCompactionTask(long flushId, | |||
| logMessage.append(" tabletMemory.memoryReservedForMinC() " | |||
| + getTabletMemory().memoryReservedForMinC()); | |||
| } | |||
| if (getTabletMemory() != null && getTabletMemory().getMemTable() != null) { | |||
There was a problem hiding this comment.
Was this unreachable code?
There was a problem hiding this comment.
no, removing this was a mistake made when I was adding the conditional for pause limit.
There was a problem hiding this comment.
Looking at it now wouldn't getTabletMemory().getMemTable() always be null when getTabletMemory() is null?
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactionTask.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check in MinorCompactionTask to ensure that the current number of files being set to compact are below the Pause property threshold.