Skip to content

added Pause option into minor compactions #5289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

added Pause option into minor compactions #5289

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f39670e
added Pause option into minor compactions
ArbaazKhan1 Jan 28, 2025
7eea712
Merge branch 'apache:main' into accumulo-5151
ArbaazKhan1 Mar 18, 2025
6a3fe92
Moved pause check to createMinorCompactionTask()
ArbaazKhan1 Mar 18, 2025
2de2a83
added changes
ArbaazKhan1 Apr 7, 2025
05f2c72
fixed conditional
ArbaazKhan1 May 1, 2025
1b04643
Merge branch 'main' into accumulo-5151
ArbaazKhan1 Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactionTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
*/
package org.apache.accumulo.tserver.tablet;

import org.apache.accumulo.core.conf.Property;
import org.apache.accumulo.core.file.FilePrefix;
import org.apache.accumulo.core.metadata.ReferencedTabletFile;
import org.apache.accumulo.core.metadata.schema.DataFileValue;
Expand All @@ -41,6 +42,8 @@ class MinorCompactionTask implements Runnable {
private final long flushId;
private final MinorCompactionReason mincReason;

private final long pauseLimit;

MinorCompactionTask(Tablet tablet, CommitSession commitSession, long flushId,
MinorCompactionReason mincReason) {
this.tablet = tablet;
Expand All @@ -49,6 +52,8 @@ class MinorCompactionTask implements Runnable {
this.commitSession = commitSession;
this.flushId = flushId;
this.mincReason = mincReason;
this.pauseLimit = tablet.getContext().getTableConfiguration(tablet.extent.tableId())
.getCount(Property.TABLE_FILE_PAUSE);
}

@Override
Expand Down
14 changes: 7 additions & 7 deletions server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,6 @@ DataFileValue minorCompact(InMemoryMap memTable, ReferencedTabletFile tmpDatafil
boolean failed = false;
long start = System.currentTimeMillis();
timer.incrementStatusMinor();

long count = 0;

String oldName = Thread.currentThread().getName();
Expand All @@ -394,7 +393,6 @@ DataFileValue minorCompact(InMemoryMap memTable, ReferencedTabletFile tmpDatafil
Span span = TraceUtil.startSpan(this.getClass(), "minorCompact::write");
try (Scope scope = span.makeCurrent()) {
count = memTable.getNumEntries();

MinorCompactor compactor = new MinorCompactor(tabletServer, this, memTable, tmpDatafile,
mincReason, tableConfiguration);
stats = compactor.call();
Expand Down Expand Up @@ -585,15 +583,17 @@ private MinorCompactionTask createMinorCompactionTask(long flushId,
MinorCompactionReason mincReason) {
MinorCompactionTask mct;
long t1, t2;

long pauseLimit =
getContext().getTableConfiguration(extent.tableId()).getCount(Property.TABLE_FILE_PAUSE);
StringBuilder logMessage = null;

try {
synchronized (this) {
t1 = System.currentTimeMillis();

if (isClosing() || isClosed() || getTabletMemory().memoryReservedForMinC()
|| getTabletMemory().getMemTable().getNumEntries() == 0 || updatingFlushID) {
|| updatingFlushID || (mincReason == MinorCompactionReason.SYSTEM
&& getDatafiles().size() >= pauseLimit)) {

logMessage = new StringBuilder();

Expand All @@ -603,9 +603,9 @@ private MinorCompactionTask createMinorCompactionTask(long flushId,
logMessage.append(" tabletMemory.memoryReservedForMinC() "
+ getTabletMemory().memoryReservedForMinC());
}
if (getTabletMemory() != null && getTabletMemory().getMemTable() != null) {
logMessage.append(" tabletMemory.getMemTable().getNumEntries() "
+ getTabletMemory().getMemTable().getNumEntries());
if (mincReason == MinorCompactionReason.SYSTEM) {
logMessage.append(" fileCount " + getDatafiles().size());
logMessage.append(" fileCountPauseLimit " + pauseLimit);
}
logMessage.append(" updatingFlushID " + updatingFlushID);

Expand Down