Skip to content

Conversation

DomGarguilo
Copy link
Member

This PR adds a test for the new NOT_METADATA_TABLE_ID Validator

@ctubbsii
Copy link
Member

ctubbsii commented Mar 31, 2023

Can you provide a reference for where the new Validator was added? It would help to know when / why it was added in order to understand whether the validator is supposed to be checking "not any metadata table (neither accumulo.root nor accumulo.metadata, nor any other future metadata table)" or "not the specific metadata table named accumulo.metadata".

Also, it would help explain why the elasticity branch is being targeted instead of the main branch.

@DomGarguilo
Copy link
Member Author

DomGarguilo commented Mar 31, 2023

The new NOT_METADATA_TABLE_ID Validator was added as part of #3250.

This PR is targeting the elasticity branch because it contains the changes made in #3250 which include the new Validator where main does not yet have these changes nor the new Validator.

Copy link
Contributor

@dlmarion dlmarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

@DomGarguilo DomGarguilo merged commit 576c9cc into apache:elasticity Apr 3, 2023
@DomGarguilo DomGarguilo deleted the addValidatorTest branch April 3, 2023 15:15
@ctubbsii ctubbsii added this to the 4.0.0 milestone Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants