Improves scan server resolution in batch scanner code. #3273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors the batch scanner code to make two improvements. First mapping ranges to scan servers or tservers was moved under one method. Second the process of mapping ranges to scan servers using the tablet location cache was improved. The tablet location cache used to organized data in a a way that was useful for immediate scans and eventual scans had to reorganize the data. A new method was added to the tablet location cache that passes the raw data to a consumer that can orgranize it in any way. This new method is used for scan servers.
|
Looks good, kicking off full IT build for this. |
Ok going to merge thjis w/ same reason as #3272 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the batch scanner code to make two improvements. First mapping ranges to scan servers or tservers was moved under one method. Second the process of mapping ranges to scan servers using the tablet location cache was improved. The tablet location cache used to organized data in a a way that was useful for immediate scans and eventual scans had to reorganize the data. A new method was added to the tablet location cache that passes the raw data to a consumer that can orgranize it in any way. This new method is used for scan servers.