-
Notifications
You must be signed in to change notification settings - Fork 467
Run FindCompactionTmpFiles utility via accumulo Admin #4465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Should there be a check to see if the system is up or if there running compactions? If this was run on a system with active compactions, would it find and delete files that were currently being written to be the compaction process? As a stand-alone utility it is a little harder to run the command - if elevated to an admin utility, would that increase the chances that it would be run on an active system? |
FindCompactionTmpFiles first finds the tmp files, then removes from that set any file that is referenced from currently executing compactions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I think you may want to add some tests to FindCompactionTmpFilesIT to test it using the Admin pathway. You can look at DumpConfigIT an an example on how to call Admin and pass the parameters.
May want to wait on merging this until after #4807 is merged, because I suspect there will be conflicts, or at least some related changes. |
Any update on this? Think it just needs an IT |
Added command option
FindCompactionTmpFIles
to admin commands.closes issue #3986