Modified TabletsMetadata to run filters on root tablet #5648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filters on TabletMetadata were not being applied to the root tablet metadata causing an exception in in Manager.shouldCleanupMigration. The code was applying a filter to only return tablet metadata that contained a migration, then checking that the migration was not null. Because the filter was not being applied to the root tablet, it was being returned as matching the filter but with no migration. Applying the fix in TabletsMetadata to run the filter on the root tablet metadata caused a subsequent issue in the GcWalsFilter where acceptTablet() would return null. Modified TabletMetadataFilter to protect against this condition. Closes apache#5643
kevinrr888
reviewed
Jun 16, 2025
core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletsMetadata.java
Outdated
Show resolved
Hide resolved
| private TabletsMetadata buildRoot(AccumuloClient client) throws IOException { | ||
| final RootTabletMetadata rtm = getRootMetadata(client); | ||
| if (!tabletMetadataFilters.isEmpty()) { | ||
| final SortedMapIterator iter = new SortedMapIterator(rtm.toKeyValues()); |
There was a problem hiding this comment.
probably need to use ColumnFamilySkippingIterator to skip column fams
| for (DataLevel level : groupedExtents.keySet()) { | ||
| if (level == DataLevel.ROOT) { | ||
| iterables.add(() -> Iterators.singletonIterator(getRootMetadata((ClientContext) client))); | ||
| iterables.add(() -> Iterators |
There was a problem hiding this comment.
should this use the new buildroot function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filters on TabletMetadata were not being applied to the root tablet metadata causing an exception in in Manager.shouldCleanupMigration. The code was applying a filter to only return tablet metadata that contained a migration, then checking that the migration was not null. Because the filter was not being applied to the root tablet, it was being returned as matching the filter but with no migration.
Applying the fix in TabletsMetadata to run the filter on the root tablet metadata caused a subsequent issue in the GcWalsFilter where acceptTablet() would return null. Modified TabletMetadataFilter to protect against this condition.
Closes #5643