Made AbstractServer.hostname volatile #5656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Monitor calls `getMetrics` on each server to get their information, and `getMetrics` logs an a message if the hostname is `0.0.0.0` and returns an empty response. Saw these messages in the gc server log, but SimpleGarbageCollector sets the hostname immediately after starting the Thrift service in `startStatsService`.
ddanielr
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Monitor calls
getMetricson each server to get their information, andgetMetricslogs an a message if the hostname is0.0.0.0and returns an empty response. Saw these messages in the gc server log, but SimpleGarbageCollector sets the hostname immediately after starting the Thrift service instartStatsService.