ARTEMIS-5534 use Objects.requireNonNullElse() where sensible #5771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabish121
reviewed
Jun 11, 2025
...mmons/src/main/java/org/apache/activemq/artemis/utils/collections/ConcurrentLongHashMap.java
Outdated
Show resolved
Hide resolved
tabish121
reviewed
Jun 11, 2025
...mis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTUtil.java
Outdated
Show resolved
Hide resolved
jbertram
force-pushed
the
ARTEMIS-5534
branch
6 times, most recently
from
033e50c to
b3c00a2
Compare
The code-base is littered with uses of Java's ternary operator to check for null and fallback to a default value. Many of these can be replaced with either `Objects.requireNonNullElse` or `Objects.requireNonNullElseGet`. The latter is used where appropriate to essentially match the short-circuit semantics provided by the ternary operator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code-base is littered with uses of Java's ternary operator to check for null and fallback to a default value. Many of these can be replaced with either
Objects.requireNonNullElseorObjects.requireNonNullElseGet. The latter is used where appropriate to essentially match the short-circuit semantics provided by the ternary operator.