Skip to content

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jan 12, 2025

No description provided.

@potiuk potiuk requested review from jscheffl, kaxil and shahar1 January 12, 2025 08:48
@potiuk potiuk force-pushed the bump-theme-version branch from ee7de9c to c613be0 Compare January 12, 2025 08:49
@potiuk
Copy link
Member Author

potiuk commented Jan 12, 2025

I have big troubles in building the theme locally - but I think the packages are published as artifacts here and I should be able to download it from here and upload to PyPI

@potiuk
Copy link
Member Author

potiuk commented Jan 12, 2025

However. I am not sure what's going to happen if we publish it together with the old HTML code for past versions :) ?

@shahar1
Copy link
Contributor

shahar1 commented Jan 12, 2025

However. I am not sure what's going to happen if we publish it together with the old HTML code for past versions :) ?

Good point, past versions will get broken as we don't pin the version in past versions.
Maybe we should create a completely new package just in case?

@potiuk
Copy link
Member Author

potiuk commented Jan 12, 2025

However. I am not sure what's going to happen if we publish it together with the old HTML code for past versions :) ?

Good point, past versions will get broken as we don't pin the version in past versions. Maybe we should create a completely new package just in case?

We can set "sphinx-airflow-theme>=0.0.12, <0.1.0" in v2-10-test and providers-fab/v1-5.

@potiuk
Copy link
Member Author

potiuk commented Jan 12, 2025

Though I think css is shared so the css should have support for both old and new formatting (cc: @jscheffl )

@potiuk potiuk merged commit a03a6e3 into main Jan 12, 2025
1 check passed
@eladkal eladkal deleted the bump-theme-version branch April 10, 2025 14:42
potiuk added a commit that referenced this pull request May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants