refactor(utils/decorators): rewrite remove task decorator to use cst #43383
+91
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josix
force-pushed
the
refactor/remove_task_decorator
branch
2 times, most recently
from
991cccc to
4e926d5
Compare
josix
force-pushed
the
refactor/remove_task_decorator
branch
2 times, most recently
from
d5e6684 to
606b2ea
Compare
josix
commented
Oct 25, 2024
josix
force-pushed
the
refactor/remove_task_decorator
branch
from
1ec8a0a to
28d8f2c
Compare
Lee-W
reviewed
Nov 26, 2024
josix
force-pushed
the
refactor/remove_task_decorator
branch
from
28d8f2c to
2a82c10
Compare
josix
force-pushed
the
refactor/remove_task_decorator
branch
from
2a82c10 to
f2cbefa
Compare
josix
force-pushed
the
refactor/remove_task_decorator
branch
4 times, most recently
from
292076c to
066d757
Compare
josix
commented
Jan 27, 2025
| @@ -192,25 +192,25 @@ def test_should_create_virtualenv_with_extra_packages_uv(self, mock_execute_in_s | |||
| ) | |||
|
|
|||
| def test_remove_task_decorator(self): | |||
| py_source = '@task.virtualenv(serializer="dill")\ndef f():\nimport funcsigs' | |||
| py_source = '@task.virtualenv(serializer="dill")\ndef f():\n import funcsigs' | |||
There was a problem hiding this comment.
note. the original syntax is invalid due to the indentation error.
josix
force-pushed
the
refactor/remove_task_decorator
branch
from
066d757 to
324301b
Compare
josix
changed the title
Lee-W
reviewed
Feb 3, 2025
providers/standard/tests/provider_tests/standard/utils/test_python_virtualenv.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Wei Lee <[email protected]>
Co-authored-by: Wei Lee <[email protected]>
Co-authored-by: Wei Lee <[email protected]>
josix
force-pushed
the
refactor/remove_task_decorator
branch
from
6631ea8 to
bc09e4b
Compare
Lee-W
reviewed
Feb 4, 2025
| @@ -192,25 +193,77 @@ def test_should_create_virtualenv_with_extra_packages_uv(self, mock_execute_in_s | |||
| ) | |||
|
|
|||
| def test_remove_task_decorator(self): | |||
There was a problem hiding this comment.
nits: we probably could refactor these cases through pytest.mark.parametrize (remember to use id to make it more readable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
due to #42766 the dropping of python3.8 support, I rewrite the
remove_task_decoratorto achieve the same purpose through CST.TODO:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.