Skip to content

AIP-84 Allow only positive limit and offset #44109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 18, 2024
Merged

AIP-84 Allow only positive limit and offset #44109

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
45ada86
limit and offset can't be negative
rawwar Nov 17, 2024
9af0aae
add tests
rawwar Nov 17, 2024
18c5412
refactor
rawwar Nov 17, 2024
32df34e
use NonNegativeInt
rawwar Nov 18, 2024
c8e113d
Merge branch 'main' of https://github.com/apache/airflow into kalyan/…
rawwar Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions airflow/api_fastapi/common/parameters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ def to_orm(self, select: Select) -> Select:
return select.limit(self.value)

def depends(self, limit: int = 100) -> LimitFilter:
if limit < 0:
raise HTTPException(400, "Limit cannot be negative.")
return self.set_value(limit)


Expand All @@ -88,6 +90,8 @@ def to_orm(self, select: Select) -> Select:
return select.offset(self.value)

def depends(self, offset: int = 0) -> OffsetFilter:
if offset < 0:
raise HTTPException(400, "Offset cannot be negative.")
return self.set_value(offset)


Expand Down
Loading