Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-84: Migrating DELETE queued asset events for DAG to fastAPI #44129

Conversation

amoghrajesh
Copy link
Contributor

related: #42370
Migrating delete queued asset events for DAG to fastAPI

Dependent on #44124

Same setup as #44124

Responses:

  1. Legacy
    image

  2. FastAPI
    image

With time filtering

  1. Legacy
    image

  2. FastAPI
    image

Time filtering but no queued event found

  1. Legacy
    image

  2. FastAPI
    image


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@amoghrajesh amoghrajesh added the legacy api Whether legacy API changes should be allowed in PR label Nov 18, 2024
@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Nov 18, 2024
@amoghrajesh amoghrajesh changed the title Aip84 delete all queued events for dag again AIP-84: Migrating delete queued asset events for DAG to fastAPI Nov 18, 2024
@amoghrajesh amoghrajesh self-assigned this Nov 18, 2024
@amoghrajesh amoghrajesh changed the title AIP-84: Migrating delete queued asset events for DAG to fastAPI AIP-84: Migrating DELETE queued asset events for DAG to fastAPI Nov 18, 2024
@amoghrajesh
Copy link
Contributor Author

@Lee-W @rawwar I pushed a fix for the reviews, can you check again?

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pierrejeambrun pierrejeambrun merged commit 6c3caa6 into apache:main Nov 18, 2024
62 checks passed
@pierrejeambrun pierrejeambrun deleted the AIP84-delete-all-queued-events-for-dag-again branch November 18, 2024 13:57
amoghrajesh added a commit to astronomer/airflow that referenced this pull request Nov 18, 2024
…he#44129)

* AIP-84: Migrating GET queued asset events for DAG to fastAPI

* fixing tests and server code

* fixing parameters

* fixing parameters

* AIP-84: Migrating delete queued asset events for DAG to fastAPI

* adding assert for count

* review comments from kalyan
kandharvishnu pushed a commit to kandharvishnu/airflow that referenced this pull request Nov 19, 2024
…he#44129)

* AIP-84: Migrating GET queued asset events for DAG to fastAPI

* fixing tests and server code

* fixing parameters

* fixing parameters

* AIP-84: Migrating delete queued asset events for DAG to fastAPI

* adding assert for count

* review comments from kalyan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. legacy api Whether legacy API changes should be allowed in PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants